unical1988 commented on code in PR #669:
URL: https://github.com/apache/incubator-xtable/pull/669#discussion_r2041095246
##########
xtable-api/src/main/java/org/apache/xtable/model/storage/InternalDataFile.java:
##########
@@ -52,4 +52,20 @@ public class InternalDataFile extends InternalFile {
@Builder.Default @NonNull List<ColumnStat> columnStats =
Collections.emptyList();
// last modified time in millis since epoch
long lastModified;
+ public static InternalDataFileBuilder builderFrom(InternalDataFile dataFile)
{
+ return dataFile.toBuilder();
+ }
+
+ public static boolean compareFiles(InternalDataFile obj1, InternalDataFile
obj2) {
Review Comment:
Seems more relevant to keep it there. but the question is should the test
include internaldatafiles or just the stats, I think I will have to add methods
to compare Range, Field and ColumnStat as well, they could be named
`.equals()`... inside the respective classes.
##########
xtable-api/src/main/java/org/apache/xtable/model/storage/InternalDataFile.java:
##########
@@ -52,4 +52,20 @@ public class InternalDataFile extends InternalFile {
@Builder.Default @NonNull List<ColumnStat> columnStats =
Collections.emptyList();
// last modified time in millis since epoch
long lastModified;
+ public static InternalDataFileBuilder builderFrom(InternalDataFile dataFile)
{
+ return dataFile.toBuilder();
+ }
+
+ public static boolean compareFiles(InternalDataFile obj1, InternalDataFile
obj2) {
Review Comment:
Seems more relevant to keep it there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
