the-other-tim-brown commented on code in PR #669:
URL: https://github.com/apache/incubator-xtable/pull/669#discussion_r2041139548
##########
xtable-api/src/main/java/org/apache/xtable/model/storage/InternalDataFile.java:
##########
@@ -52,4 +52,20 @@ public class InternalDataFile extends InternalFile {
@Builder.Default @NonNull List<ColumnStat> columnStats =
Collections.emptyList();
// last modified time in millis since epoch
long lastModified;
+ public static InternalDataFileBuilder builderFrom(InternalDataFile dataFile)
{
+ return dataFile.toBuilder();
+ }
+
+ public static boolean compareFiles(InternalDataFile obj1, InternalDataFile
obj2) {
Review Comment:
there is already an `equals` method generated for the class by lombok, there
is no need for a custom implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
