unical1988 commented on code in PR #728:
URL: https://github.com/apache/incubator-xtable/pull/728#discussion_r2227242827
##########
xtable-core/src/test/java/org/apache/xtable/ITConversionController.java:
##########
@@ -141,7 +140,7 @@ private static Stream<Arguments>
testCasesWithPartitioningAndSyncModes() {
private static Stream<Arguments>
generateTestParametersForFormatsSyncModesAndPartitioning() {
List<Arguments> arguments = new ArrayList<>();
- for (String sourceTableFormat : Arrays.asList(HUDI, DELTA, ICEBERG)) {
+ for (String sourceTableFormat : Arrays.asList(HUDI, DELTA, ICEBERG,
PARQUET)) {
Review Comment:
I notice you start the tests by creating a SparkSession, can we leverage it
for creating the parquet file to convert into 3 other formats? is a call to
`conversionController.sync(conversionConfig, conversionSourceProvider);
`sufficient to test the coversion? do you validate the converted data through
`checkDatasetEquivalence()` (all of `ITConversionController.java`) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
