unical1988 commented on code in PR #728:
URL: https://github.com/apache/incubator-xtable/pull/728#discussion_r2224252168
##########
xtable-core/src/main/java/org/apache/xtable/hudi/ConfigurationBasedPartitionSpecExtractor.java:
##########
@@ -29,20 +29,21 @@
import org.apache.xtable.model.schema.InternalPartitionField;
import org.apache.xtable.model.schema.InternalSchema;
import org.apache.xtable.schema.SchemaFieldFinder;
+import org.apache.xtable.model.schema.PartitionFieldSpec;
/**
* Parses the InternalPartitionFields from a configured list of specs with the
format
* path:type:format for date types or path:type for value types.
*/
@AllArgsConstructor
-public class ConfigurationBasedPartitionSpecExtractor implements
HudiSourcePartitionSpecExtractor {
+public class ConfigurationBasedPartitionSpecExtractor implements
PathBasedPartitionSpecExtractor {
private final HudiSourceConfig config;
Review Comment:
not sure I totally understood this, but I have replaced config with an
attribute with type List<PartitionFieldSpec>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
