the-other-tim-brown commented on code in PR #766:
URL: https://github.com/apache/incubator-xtable/pull/766#discussion_r2627389865
##########
xtable-api/src/main/java/org/apache/xtable/model/schema/InternalField.java:
##########
@@ -43,6 +43,7 @@ public class InternalField {
// The id field for the field. This is used to identify the field in the
schema even after
// renames.
Integer fieldId;
+ @Getter String storageName;
Review Comment:
@xr-chen "name mapping" is a delta specific concept. The comment should
describe more generally what is happening here. Something like `The name of the
column in the data file used to store this field when it differs from the name
in table's definition`
The comment should also describe whether this will be `null` when the names
are the same or if the string is expected to be populated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
