xr-chen commented on code in PR #766:
URL: https://github.com/apache/incubator-xtable/pull/766#discussion_r2629214953
##########
xtable-core/src/test/java/org/apache/xtable/ITConversionController.java:
##########
@@ -746,6 +746,29 @@ public void testIcebergCorruptedSnapshotRecovery() throws
Exception {
}
}
+ @Test
+ public void testColumnMappingEnabledDeltaToIceberg() {
Review Comment:
Ahh, it's due to the `idToStorageName` field I added to the
`IcebergSchemaExtractor`, the field wasn't reset before a new sync run, and the
schema extractor was used as a singleton, so previous extraction results were
carried over to the next run, which fails the test. Now the `mvn clean verify`
passed on my end
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
