the-other-tim-brown commented on code in PR #772:
URL: https://github.com/apache/incubator-xtable/pull/772#discussion_r3368132195


##########
xtable-hudi-support/xtable-hudi-support-utils/src/main/java/org/apache/xtable/hudi/idtracking/IdTracker.java:
##########
@@ -122,12 +124,63 @@ public IdTracking getIdTracking(
     AtomicInteger currentId = new AtomicInteger(existingState.getLastIdUsed());
     // add meta fields to the schema in order to ensure they will be assigned 
IDs
     Schema schemaForIdMapping =
-        includeMetaFields ? HoodieAvroUtils.addMetadataFields(schema) : schema;
-    List<IdMapping> newMappings =
-        generateIdMappings(schemaForIdMapping, currentId, 
existingState.getIdMappings());
-    return new IdTracking(newMappings, currentId.get());
+        includeMetaFields
+            ? 
HoodieSchemaUtils.addMetadataFields(HoodieSchema.fromAvroSchema(schema))
+                .toAvroSchema()
+            : schema;
+    if (currentId.intValue() != 0) {

Review Comment:
   I'm curious if this is an existing bug or something that happens due to 
changes in Hudi.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to