the-other-tim-brown commented on code in PR #772:
URL: https://github.com/apache/incubator-xtable/pull/772#discussion_r3492406864
##########
xtable-hudi-support/xtable-hudi-support-utils/src/test/java/org/apache/xtable/hudi/idtracking/TestIdTracker.java:
##########
@@ -341,28 +498,28 @@ private static IdTracking
getExpectTrackingForComplexSchemaEvolvedNoMetaFields()
"double_nested",
13,
Collections.singletonList(new
IdMapping("double_nested_int", 14))),
- new IdMapping("level", 20))))),
+ new IdMapping("level", 18))))),
new IdMapping(
"primitive_map_field",
6,
Arrays.asList(new IdMapping("key", 15), new IdMapping("value",
16))),
new IdMapping(
"array_field",
- 17,
+ 19,
Collections.singletonList(
new IdMapping(
"element",
- 21,
+ 20,
Arrays.asList(
- new IdMapping("nested_int", 22),
+ new IdMapping("nested_int", 21),
new IdMapping(
"double_nested",
- 23,
- Collections.singletonList(new
IdMapping("double_nested_int", 25))),
- new IdMapping("level", 24))))),
+ 22,
Review Comment:
but why is the code path changing as part of the upgrade? will this break
integrations for users?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]