the-other-tim-brown commented on code in PR #772:
URL: https://github.com/apache/incubator-xtable/pull/772#discussion_r3492434534


##########
xtable-core/src/main/java/org/apache/xtable/hudi/HudiConversionTarget.java:
##########
@@ -607,7 +635,15 @@ private HoodieWriteConfig getWriteConfig(
               HoodieMetadataConfig.newBuilder()
                   .enable(true)
                   .withProperties(properties)
-                  .withMetadataIndexColumnStats(true)
+                  // Hudi 1.2.0 couples the partition-stats index to the 
column-stats index. For
+                  // partitioned tables the
+                  // partition-stats generation path rebuilds a file-system 
view over the committed
+                  // external
+                  // parquet files and groups them by fileId; XTable's 
externally-registered files
+                  // have non-Hudi names
+                  // whose fileId cannot be parsed once the "_hudiext" marker 
is stripped, leading
+                  // to failures.

Review Comment:
   nit: fix formatting of the comments here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to