AadhiKat commented on code in PR #861:
URL: https://github.com/apache/incubator-xtable/pull/861#discussion_r3641885912
##########
xtable-core/src/test/java/org/apache/xtable/delta/ITDeltaConversionSource.java:
##########
@@ -829,4 +836,54 @@ private boolean checkIfFileIsRemoved(String activePath,
TableChange tableChange)
.collect(Collectors.toSet());
return filePathsRemoved.contains(activePath);
}
+
+ @Test
+ public void
getTableChangeForCommitReconstructsSnapshotOnceForAppendOnlyBacklog() {
Review Comment:
Added the two-run test you suggested
(`incrementalSyncWatermarkAdvancesAndDoesNotReprocessSyncedCommits`):
sync a multi-commit backlog, append a couple more, sync again from the
watermark, and
assert the second backlog leaves out the already-synced versions. Kept the
`getSnapshotAt` call-count test too.
mvn clean install is green locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
