rangareddy commented on PR #857: URL: https://github.com/apache/incubator-xtable/pull/857#issuecomment-5188184574
@vinishjail97 the License Check failure on the previous push was the new gate working, and it turned up something worth knowing before rc2. Pushed `a611ada`; CI should be green now. **The License Check has never actually run in CI.** The script builds its module list with `rg`, which `mvn-license-check.yml` does not install and which **the GitHub `ubuntu-latest` runner does not ship**. The call sits inside a process substitution, so `set -o errexit` cannot see it fail; the list came back empty and the script hit its `exit 0` path. From the [most recent License Check on `main`](https://github.com/apache/incubator-xtable/actions/runs/30717785654): ``` release/scripts/validate_shaded_license_coverage.sh: line 92: rg: command not found No modules with maven-shade-plugin were found. ``` Every one of the last ten runs on `main` is green for that reason. I need to correct myself here — in my earlier reply I said the runner happened to have ripgrep and the gate "works in CI only by luck". That was wrong: it has never run. **What that was hiding** Replacing `rg` with `find`/`grep` made the gate run for the first time, and it immediately failed on `xtable-hive-metastore`'s existing `<includes>`-vs-runtime-tree assertion: 25 includes name dependencies that are no longer resolved (`ant:ant`, `asm:*`, `javax.mail:mail`, `oro:oro`, `tomcat:jasper-*`, …) and 97 runtime dependencies are missing from the list (all of jetty 9.x, jersey 2.x, hk2, calcite, the `hbase-*` server modules, …). It reads as a list written for a Hive 2.x dependency set and never updated for 3.1.3. To confirm this is not something I introduced: this PR touches no `pom.xml`, and running **`main`'s own unmodified validator** with ripgrep available reproduces the identical failure. **How I have handled it, and why not more** Filed as #880 with the full evidence, and this PR adds an explicit one-module `KNOWN_INCLUDES_DRIFT` entry that downgrades **only** the includes-vs-tree comparison for **only** `xtable-hive-metastore` to a loud `WARN` printing the full diff and referencing #880. Every other check, for every module, stays blocking — I verified the scoping by planting a bogus `<include>` in `xtable-aws`, which still fails. I did not fix the drift here because the two candidate fixes have materially different consequences for the published artifact: 1. **Grow the include list to match the tree**, which is what AGENTS.md currently prescribes. That would bundle all of jetty, jersey, hk2, calcite and the hbase server modules into the shaded jar, changing its contents and size significantly, plus ~15 more bundled license texts. 2. **Narrow those dependencies to `provided`**, if the expectation is that a Hive Metastore deployment supplies them. In that case the include list is closer to correct than the tree is, and the validator's "must exactly match" contract itself deserves another look. That is a release/design call rather than a tooling fix, so it seemed wrong to decide it inside a license-text PR — and worse to leave the gate vacuous in order to avoid it. Happy to do either once you or `dev@` pick one. Two things you may want to consider separately, given the gate has not been effective on any branch: - whether `mvn-license-check.yml` should also run on `branch-0.4`; - whether 0.4.0-incubating rc1 was validated by this gate at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
