vinishjail97 commented on PR #857: URL: https://github.com/apache/incubator-xtable/pull/857#issuecomment-5209331168
Replacing my earlier comment on scope, now that I have a concrete alternative to point at rather than just a suggestion. ### Suggestion: check the built jar instead of generating from the poms I pushed one as #885 — `release/scripts/validate_bundled_license_texts.py`, 152 lines. It reads each `*-bundled.jar`, takes the coordinate listing from that jar's own `META-INF/LICENSE`, confirms each non-Apache-2.0 coordinate's classes are genuinely present, and requires `META-INF/licenses/LICENSE-<artifactId>`. It fails in both directions, so an orphaned text fails too. Reading the artifact rather than the dependency tree removes the need for POM family resolution, the override tables, the parse fallbacks and the `<includes>` intersection — and with them the dependency on #880, since the check no longer cares what the includes list claims. #885 reuses your curated texts as-is; that curation is the part of this PR that has to happen whichever mechanism produces the metadata, and it is genuinely careful work. ### On duplication Measured across the 51 license files in this PR: **25 distinct texts, 9,050 lines of content, of which 2,681 are distinct and 6,369 are duplicates.** The single largest item is the CDDL 1.1 text — 759 lines, committed **8 times**: `jersey-client`, `jersey-guice`, `jersey-json` and `stax-api`, each in both `license_overrides/` and `xtable-hive-metastore/`. That one text is larger than everything else in the PR put together, including all 653 lines of code. Two causes: - `license_overrides/` is a second committed copy of every text that also lands in a module. It exists to feed the generator, so dropping the generator drops the layer. - `LICENSE-<artifactId>` forces one copy per artifact even where several artifacts share identical boilerplate. A single `licenses/LICENSE-CDDL-1.1`, named from the `LICENSE-bundled` entries, would remove roughly 2,300 lines from `xtable-hive-metastore` alone. That is a convention change worth agreeing before either patch lands — it applies equally to #885, which currently has the same problem. ### One process request Could the description be trimmed? It has grown past what a reviewer can hold in one pass, and parts of it no longer match the head commit: open item 1 still says the generator refuses on `javolution`, but the `ARTIFACT_OVERRIDES` entry resolves it and a clean run does not stop there; and the `xtable-hive-metastore` count of 21 does not match a clean run, which writes 20. Since this description is what the rc2 vote thread will point at, something short and current would serve it better. Happy to help condense it if that is useful. Numbers above come from builds of both `main` and `branch-0.4`; the method is in #885. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
