vinishjail97 commented on code in PR #881:
URL: https://github.com/apache/incubator-xtable/pull/881#discussion_r3732269418
##########
pom.xml:
##########
@@ -61,13 +61,13 @@
<project.version>0.2.0-SNAPSHOT</project.version>
<!-- To ensure build content is re-producible -->
<project.build.outputTimestamp>2026-07-21T19:16:22Z</project.build.outputTimestamp>
- <maven.compiler.target>8</maven.compiler.target>
+ <javaVersion>8</javaVersion>
<maven-compiler-plugin.version>3.13.0</maven-compiler-plugin.version>
<avro.version>1.12.0</avro.version>
<log4j.version>2.22.0</log4j.version>
<junit.version>5.11.4</junit.version>
<junit.platform.runner.version>1.11.4</junit.platform.runner.version>
- <lombok.version>1.18.36</lombok.version>
+ <lombok.version>1.18.46</lombok.version>
Review Comment:
I verified this locally: on `origin/main` with JDK 21 the delombok failure
reproduces exactly as described (`NoSuchFieldError: Class
com.sun.tools.javac.tree.JCTree$JCImport does not have member field
'com.sun.tools.javac.tree.JCTree qualid'`), and with this change the build gets
past it. Thanks for digging into this.
One thing worth noting for the stated goal of building locally on a current
JDK: the build still doesn't complete on JDK 21, it just fails a step later at
spotless instead:
```
You are running Spotless on JVM 21. This requires google-java-format of at
least 1.17.0 (you are using 1.10.0).
```
It builds fine with `-Dspotless.check.skip=true`, so this doesn't take
anything away from the change here. Is it possible to upgrade the
google-java-format version so a modern JDK works end to end?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
