slachiewicz commented on code in PR #881:
URL: https://github.com/apache/incubator-xtable/pull/881#discussion_r3740280547
##########
pom.xml:
##########
@@ -61,13 +61,13 @@
<project.version>0.2.0-SNAPSHOT</project.version>
<!-- To ensure build content is re-producible -->
<project.build.outputTimestamp>2026-07-21T19:16:22Z</project.build.outputTimestamp>
- <maven.compiler.target>8</maven.compiler.target>
+ <javaVersion>8</javaVersion>
<maven-compiler-plugin.version>3.13.0</maven-compiler-plugin.version>
<avro.version>1.12.0</avro.version>
<log4j.version>2.22.0</log4j.version>
<junit.version>5.11.4</junit.version>
<junit.platform.runner.version>1.11.4</junit.platform.runner.version>
- <lombok.version>1.18.36</lombok.version>
+ <lombok.version>1.18.46</lombok.version>
Review Comment:
Thanks to this change, project can be compiled with newer Java without
waitnig to fix spotless by typical developers and only force to use Java 11 for
release.
For sure there are options but may was about to step by step.
For our other projects we are using plantir formatter but that four be
future work.
My goal was to help with licenses cleanup and this PR was kind of
prerequisite.
Happy to help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
