slachiewicz opened a new pull request, #917:
URL: https://github.com/apache/incubator-xtable/pull/917
## What is the purpose of the pull request
Closes #916. Three places where `rest-service-open-api.yaml` describes
something other than what
`xtable-service` does. The first is the one worth reviewing: a client that
follows the spec as
published sends a request the service rejects.
## Brief change log
- Added `source-data-path` to `ConvertTableRequest`, as required.
`ConversionService` passes it to
`TargetTable.basePath`, which `ExternalTable` declares `@NonNull`, with no
fallback -- so the four
documented required fields are not a valid request. #916 covers the
alternative fix, defaulting
it in `ConversionService`; this PR takes the spec-only route.
- Narrowed the `configurations` description. Only `partition-spec` is read
(`ConversionService.java:195`); every other key is discarded. It no longer
advertises itself as a
place for storage credentials, which the service does not read from there
and which a request body
should not carry -- bodies are logged, traced and cached.
- Dropped `ErrorModel.stack`. Nothing populates it: there is no `ErrorModel`
class and no
`ExceptionMapper` in the module. Removing it now is cheaper than removing
a stack trace that
someone has since implemented.
- Bumped `info.version` to 0.0.2, since a newly required request field and a
removed response field
are both contract changes. Happy to drop this hunk if you version the spec
on a different cadence.
## Verify this pull request
This pull request is a trivial rework / code cleanup without any test
coverage.
`cd spec && make lint` → `rest-service-open-api.yaml: OK`. No Java file is
touched, so behaviour is
unchanged; what changes is whether the contract matches it.
---
*This change was created with AI assistance.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
