kroushan-nit commented on code in PR #915:
URL: https://github.com/apache/incubator-xtable/pull/915#discussion_r3859721274
##########
website/src/theme/BlogPostItem/Container/index.js:
##########
@@ -28,9 +29,7 @@ export default function BlogPostItemContainer({children,
className}) {
{location.pathname.startsWith('/blog') ? (
<Link itemProp="url" to={permalink}>
<img
- src={withBaseUrl(image, {
- absolute: true,
- })}
+ src={withBaseUrl(image)}
Review Comment:
This also drops `absolute: true` from the card image URL, which isn't in the
change log. Intentional, or incidental to the class move? The cards render
either way — just confirming it's deliberate and not a stray edit.
##########
website/src/css/custom.css:
##########
@@ -37,6 +37,11 @@
--ifm-spacing-horizontal: 1.5rem;
--ifm-navbar-padding-horizontal: 0.75rem;
+ /* Infima defaults to 1140px, which leaves a wide monitor mostly empty on the
+ blog and release pages. */
+ --ifm-container-width: 1600px;
Review Comment:
The blog-cap explanation makes sense, but `--ifm-container-width` / `-xl`
are global Infima vars, so this widens every `.container`-wrapped page to
1600px — docs and the homepage too, not just the blog/release pages. The
verification list covers `/blog/` and `/releases/downloads` but not those.
Worth a look at docs/home on a wide viewport (wider docs = longer text lines),
or scoping the bump to a blog wrapper if the intent is blog-only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
