vinishjail97 commented on code in PR #915:
URL: https://github.com/apache/incubator-xtable/pull/915#discussion_r3861900003
##########
website/src/css/custom.css:
##########
@@ -37,6 +37,11 @@
--ifm-spacing-horizontal: 1.5rem;
--ifm-navbar-padding-horizontal: 0.75rem;
+ /* Infima defaults to 1140px, which leaves a wide monitor mostly empty on the
+ blog and release pages. */
+ --ifm-container-width: 1600px;
Review Comment:
Good catch, thank you. You are right that the `:root` override widened every
`.container` page, the docs and the release notes included.
Fixed in 234e3f61. The two variables now live on a `.blogLayoutContainer`
class that `BlogLayout` adds to its `.container` div, so only the blog list and
the single-post page grow to 1600px. Infima reads the variable on the element,
so the override takes effect there and nowhere else. The docs, the
`/releases/*` pages (which come from a docs plugin instance rather than
`BlogLayout`) and the home page return to the 1140px default.
Verified with `npm run build`: the class appears in `build/blog/index.html`
and in none of the docs, releases or home pages, and the built CSS carries the
scoped rule.
##########
website/src/theme/BlogPostItem/Container/index.js:
##########
@@ -28,9 +29,7 @@ export default function BlogPostItemContainer({children,
className}) {
{location.pathname.startsWith('/blog') ? (
<Link itemProp="url" to={permalink}>
<img
- src={withBaseUrl(image, {
- absolute: true,
- })}
+ src={withBaseUrl(image)}
Review Comment:
Deliberate, but I should have listed it, sorry. With `absolute: true`,
`withBaseUrl` resolved the thumbnail against the configured site `url`, so
every card image loaded from xtable.apache.org even under a local `npm run
start`, and a newly added cover image could not be previewed before it was
deployed. Dropping the option resolves the `src` relative to the site root,
which works the same on production and locally. I have added it to the change
log in the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
