vinishjail97 commented on code in PR #912:
URL: https://github.com/apache/incubator-xtable/pull/912#discussion_r3984452434
##########
xtable-core/src/main/java/org/apache/xtable/kernel/DeltaKernelSchemaExtractor.java:
##########
@@ -53,6 +53,17 @@
public class DeltaKernelSchemaExtractor {
private static final String DELTA_COLUMN_MAPPING_ID =
"delta.columnMapping.id";
+ private static final String DELTA_COLUMN_MAPPING_NAME =
"delta.columnMapping.physicalName";
Review Comment:
I see these constants being duplicated..can we move this to a common delta
class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
