vinishjail97 commented on code in PR #912:
URL: https://github.com/apache/incubator-xtable/pull/912#discussion_r4010436937
##########
xtable-core/src/main/java/org/apache/xtable/kernel/DeltaKernelSchemaExtractor.java:
##########
@@ -53,6 +53,17 @@
public class DeltaKernelSchemaExtractor {
private static final String DELTA_COLUMN_MAPPING_ID =
"delta.columnMapping.id";
+ private static final String DELTA_COLUMN_MAPPING_NAME =
"delta.columnMapping.physicalName";
Review Comment:
Moved them to a package level `org.apache.xtable.delta.Constants`, following
the style of `org.apache.xtable.catalog.Constants`. It holds the column mapping
keys, the nested ids key, and the parquet child names, and both schema
extractors now take them by static import.
`delta.generationExpression` was in the same shape, declared in three
classes, so it moved as well. The copy in `DeltaKernelSchemaExtractor` was
unused, and the two partition extractors and their tests now read the shared
one.
The tests still write the raw key strings, so they keep guarding the exact
values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
