vinishjail97 commented on code in PR #935: URL: https://github.com/apache/incubator-xtable/pull/935#discussion_r4252262909
########## xtable-core/src/main/java/org/apache/xtable/hudi/engine/HudiExecutionEngineProviderFactory.java: ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.xtable.hudi.engine; + +import lombok.AccessLevel; +import lombok.NoArgsConstructor; + +import org.apache.hadoop.conf.Configuration; +import org.apache.spark.serializer.KryoSerializer; +import org.apache.spark.sql.SparkSession; + +import org.apache.xtable.hudi.HudiTargetConfig; + +/** Creates the {@link HudiExecutionEngineProvider} selected by the Hudi target configuration. */ +@NoArgsConstructor(access = AccessLevel.PRIVATE) +public class HudiExecutionEngineProviderFactory { + + public static HudiExecutionEngineProvider createProvider( + HudiTargetConfig targetConfig, Configuration configuration) { + if (targetConfig.getExecutionEngine() == HudiTargetConfig.ExecutionEngine.SPARK) { + return new SparkExecutionEngineProvider(getOrCreateSparkSession(configuration)); Review Comment: The `xtable-utilities` bundle shades `hudi-java-client` but not `hudi-spark-client`, so I think `execution.engine=spark` fails with `NoClassDefFoundError` in `RunSync`. The default Java path should still load, since the Spark classes resolve lazily, but every `xtable-core` test has Spark on the classpath. Could a quick `RunSync` run with the bundled jar confirm the Java path, and could the config Javadoc say that `spark` needs Hudi's Spark bundle? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
