vinishjail97 commented on code in PR #935:
URL: https://github.com/apache/incubator-xtable/pull/935#discussion_r4226931108
##########
xtable-core/src/main/java/org/apache/xtable/hudi/HudiConversionTarget.java:
##########
@@ -482,6 +501,36 @@ private Optional<TableSyncMetadata> getMetadata(
}
}
+ /**
+ * Registers a definition for every secondary index partition that has none.
Hudi updates every
+ * secondary index on each commit through its definition, but the commit
that creates the metadata
+ * table rewrites the column-stats index definition from a stale view of the
definitions, which
+ * drops the secondary index definition registered in the same commit.
+ */
+ static void restoreSecondaryIndexDefinitions(HoodieTableMetaClient
metaClient) {
Review Comment:
Done in ee95125b. This PR now supports one secondary index column without
the indexer, so the remaining secondary index code in `HudiConversionTarget` is
one check before the commit. Multiple columns need Hudi's indexer, whose failed
builds leave an index definition and an inflight `indexing` instant that break
later commits, so that is left to a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
