the-other-tim-brown commented on code in PR #947:
URL: https://github.com/apache/incubator-xtable/pull/947#discussion_r4656009110
##########
xtable-core/src/main/java/org/apache/xtable/hudi/index/HudiBackedSecondaryIndexReader.java:
##########
@@ -229,8 +229,9 @@ public Dataset<Row> lookup(SourceTable table, Dataset<Row>
keys, String columnNa
HoodiePairData<String, String> recordKeysBySecondaryKey =
tableMetadata.readSecondaryIndexDataTableRecordKeysWithKeys(
HoodieJavaRDD.of(secondaryKeys),
PARTITION_NAME_SECONDARY_INDEX_PREFIX + columnName);
- // capture the field so the closure does not serialize the index instance
- String dataPath = this.dataPath;
+ // capture the path so the closure does not serialize the index instance
+ String dataPath =
Review Comment:
why does this need to change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]