the-other-tim-brown commented on code in PR #947:
URL: https://github.com/apache/incubator-xtable/pull/947#discussion_r4656045739
##########
xtable-api/src/main/java/org/apache/xtable/conversion/ExternalTable.java:
##########
@@ -66,14 +69,17 @@ class ExternalTable {
}
protected String sanitizeBasePath(String tableBasePath) {
+ String pathWithForwardSlashes = tableBasePath.replace('\\', '/');
+ if (WINDOWS_ABSOLUTE_PATH.matcher(pathWithForwardSlashes).matches()) {
+ return new Path("file:///" + pathWithForwardSlashes).toUri().toString();
+ }
+
Path path = new Path(tableBasePath);
Preconditions.checkArgument(path.isAbsolute(), "Table base path must be
absolute");
if (path.isAbsoluteAndSchemeAuthorityNull()) {
Review Comment:
Can you try dropping the windows regex and just updating this branch to
```
return "file://" + path.toUri().getPath();```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]