Repository: zeppelin Updated Branches: refs/heads/master f80a2bd66 -> 63dfa0f4c
ZEPPELIN-1071 ] Ace-editor hidden auto-complete additional events. ### What is this PR for? Does not hide popup for Ace editor-autocomplete If the page move or click on an event occurs, the auto-completion should be hidden. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1071 ### How should this be tested? 1. Call the auto-complete in the code window (ctrl + shift + space) 2. Click anywhere without closing the pop-up. ### Screenshots (if appropriate) #### Before  #### After  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: CloverHearts <[email protected]> Closes #1099 from cloverhearts/fix/acecomplete_hide and squashes the following commits: 9946d91 [CloverHearts] ace-editor code complete event integrated into the document click event bd10ffa [CloverHearts] Merge branch 'master' into fix/acecomplete_hide af8a16e [CloverHearts] Ace-editor hidden auto-complete additional events. Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/63dfa0f4 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/63dfa0f4 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/63dfa0f4 Branch: refs/heads/master Commit: 63dfa0f4caa6963781b78b9804988789ccf496fc Parents: f80a2bd Author: CloverHearts <[email protected]> Authored: Wed Jun 29 12:45:06 2016 +0900 Committer: Prabhjyot Singh <[email protected]> Committed: Thu Jun 30 10:39:52 2016 +0530 ---------------------------------------------------------------------- zeppelin-web/src/app/notebook/notebook.controller.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/63dfa0f4/zeppelin-web/src/app/notebook/notebook.controller.js ---------------------------------------------------------------------- diff --git a/zeppelin-web/src/app/notebook/notebook.controller.js b/zeppelin-web/src/app/notebook/notebook.controller.js index 0c32361..b2f52ef 100644 --- a/zeppelin-web/src/app/notebook/notebook.controller.js +++ b/zeppelin-web/src/app/notebook/notebook.controller.js @@ -974,8 +974,9 @@ angular.module('zeppelinWebApp').controller('NotebookCtrl', $scope.suggestions = []; }; -angular.element(document).click(function(){ - angular.element('.userlist').hide(); -}); + angular.element(document).click(function(){ + angular.element('.userlist').hide(); + angular.element('.ace_autocomplete').hide(); + }); });
