Repository: zeppelin
Updated Branches:
  refs/heads/branch-0.6 a81ef065a -> c7b93e6ef


ZEPPELIN-1071 ] Ace-editor hidden auto-complete additional events.

Does not hide popup for Ace editor-autocomplete
If the page move or click on an event occurs, the auto-completion should be 
hidden.

Bug Fix

https://issues.apache.org/jira/browse/ZEPPELIN-1071

1. Call the auto-complete in the code window (ctrl + shift + space)
2. Click anywhere without closing the pop-up.

![ace_ok](https://cloud.githubusercontent.com/assets/10525473/16407960/56d71fe6-3d51-11e6-8a39-5938388de8a4.gif)
![ace_ok2](https://cloud.githubusercontent.com/assets/10525473/16407961/593ae7f4-3d51-11e6-8deb-6c7106b060c8.gif)

* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: CloverHearts <[email protected]>

Closes #1099 from cloverhearts/fix/acecomplete_hide and squashes the following 
commits:

9946d91 [CloverHearts] ace-editor code complete event integrated into the 
document click event
bd10ffa [CloverHearts] Merge branch 'master' into fix/acecomplete_hide
af8a16e [CloverHearts] Ace-editor hidden auto-complete additional events.

(cherry picked from commit 63dfa0f4caa6963781b78b9804988789ccf496fc)
Signed-off-by: Mina Lee <[email protected]>

Conflicts:
        zeppelin-web/src/app/notebook/notebook.controller.js


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/c7b93e6e
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/c7b93e6e
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/c7b93e6e

Branch: refs/heads/branch-0.6
Commit: c7b93e6efc831b99f825c201fc9ddcd78e07d4de
Parents: a81ef06
Author: CloverHearts <[email protected]>
Authored: Wed Jun 29 12:45:06 2016 +0900
Committer: Mina Lee <[email protected]>
Committed: Mon Jul 18 15:17:47 2016 +0900

----------------------------------------------------------------------
 zeppelin-web/src/app/notebook/notebook.controller.js | 4 ++++
 1 file changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/c7b93e6e/zeppelin-web/src/app/notebook/notebook.controller.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/notebook.controller.js 
b/zeppelin-web/src/app/notebook/notebook.controller.js
index 9c7a93a..b275601 100644
--- a/zeppelin-web/src/app/notebook/notebook.controller.js
+++ b/zeppelin-web/src/app/notebook/notebook.controller.js
@@ -973,5 +973,9 @@ angular.module('zeppelinWebApp').controller('NotebookCtrl',
     $scope.suggestions = [];
   };
 
+  angular.element(document).click(function(){
+    angular.element('.userlist').hide();
+    angular.element('.ace_autocomplete').hide();
+  });
 
 });

Reply via email to