Repository: zeppelin Updated Branches: refs/heads/master d0178c789 -> d9abff613
ZEPPELIN-3606. Reduce verbose InterpreterNotFoundException for getEditorSetting ### What is this PR for? Simple PR to reduce the verbose exception for getEditorSetting. ### What type of PR is it? [Bug Fix | Improvement] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3606 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjf...@apache.org> Closes #3063 from zjffdu/ZEPPELIN-3606 and squashes the following commits: cdea27da6 [Jeff Zhang] ZEPPELIN-3606. Reduce verbose InterpreterNotFoundException for getEdtiorSetting Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/d9abff61 Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/d9abff61 Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/d9abff61 Branch: refs/heads/master Commit: d9abff6130ec924b9c02742b8389d3577ebc990d Parents: d0178c7 Author: Jeff Zhang <zjf...@apache.org> Authored: Wed Jul 11 13:29:12 2018 +0800 Committer: Jeff Zhang <zjf...@apache.org> Committed: Wed Jul 11 15:34:40 2018 +0800 ---------------------------------------------------------------------- .../java/org/apache/zeppelin/socket/NotebookServer.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zeppelin/blob/d9abff61/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java ---------------------------------------------------------------------- diff --git a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java index d117486..e25ccb1 100644 --- a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java +++ b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java @@ -2518,12 +2518,14 @@ public class NotebookServer extends WebSocketServlet try { interpreter = notebook().getInterpreterFactory().getInterpreter(user, noteId, replName); + LOG.debug("getEditorSetting for interpreter: {} for paragraph {}", replName, paragraphId); + resp.put("editor", notebook().getInterpreterSettingManager(). + getEditorSetting(interpreter, user, noteId, replName)); + conn.send(serializeMessage(resp)); } catch (InterpreterNotFoundException e) { - throw new IOException("Fail to get interpreter: " + replName, e); + LOG.warn("Fail to get interpreter: " + replName); + return; } - resp.put("editor", notebook().getInterpreterSettingManager(). - getEditorSetting(interpreter, user, noteId, replName)); - conn.send(serializeMessage(resp)); } private void getInterpreterSettings(NotebookSocket conn, AuthenticationInfo subject)
