Repository: zeppelin
Updated Branches:
  refs/heads/branch-0.8 43263a030 -> b682ce16b


ZEPPELIN-3606. Reduce verbose InterpreterNotFoundException for getEditorSetting

### What is this PR for?

Simple PR to reduce the verbose exception for getEditorSetting.

### What type of PR is it?
[Bug Fix | Improvement]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3606

### How should this be tested?
* CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <[email protected]>

Closes #3063 from zjffdu/ZEPPELIN-3606 and squashes the following commits:

cdea27da6 [Jeff Zhang] ZEPPELIN-3606. Reduce verbose 
InterpreterNotFoundException for getEdtiorSetting

(cherry picked from commit d9abff6130ec924b9c02742b8389d3577ebc990d)
Signed-off-by: Jeff Zhang <[email protected]>


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/b682ce16
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/b682ce16
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/b682ce16

Branch: refs/heads/branch-0.8
Commit: b682ce16be22be312ffb41f50845063ec9839278
Parents: 43263a0
Author: Jeff Zhang <[email protected]>
Authored: Wed Jul 11 13:29:12 2018 +0800
Committer: Jeff Zhang <[email protected]>
Committed: Wed Jul 11 15:34:52 2018 +0800

----------------------------------------------------------------------
 .../java/org/apache/zeppelin/socket/NotebookServer.java   | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/b682ce16/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
----------------------------------------------------------------------
diff --git 
a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java 
b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
index 0fcb7e2..85de965 100644
--- 
a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
+++ 
b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
@@ -2462,12 +2462,14 @@ public class NotebookServer extends WebSocketServlet
         null;
     try {
       interpreter = notebook().getInterpreterFactory().getInterpreter(user, 
noteId, replName);
+      LOG.debug("getEditorSetting for interpreter: {} for paragraph {}", 
replName, paragraphId);
+      resp.put("editor", notebook().getInterpreterSettingManager().
+          getEditorSetting(interpreter, user, noteId, replName));
+      conn.send(serializeMessage(resp));
     } catch (InterpreterNotFoundException e) {
-      throw new IOException("Fail to get interpreter: " + replName, e);
+      LOG.warn("Fail to get interpreter: " + replName);
+      return;
     }
-    resp.put("editor", notebook().getInterpreterSettingManager().
-        getEditorSetting(interpreter, user, noteId, replName));
-    conn.send(serializeMessage(resp));
   }
 
   private void getInterpreterSettings(NotebookSocket conn, AuthenticationInfo 
subject)

Reply via email to