adriancole commented on a change in pull request #2589: Makes SpanBytesDecoder
work on ByteBuffer
URL: https://github.com/apache/incubator-zipkin/pull/2589#discussion_r283131622
##########
File path: benchmarks/src/main/java/zipkin2/codec/ProtoCodecBenchmarks.java
##########
@@ -87,7 +87,7 @@ public void tearDown() {
@Benchmark
public List<Span> bytebuffer_zipkinDecoder() {
- return
SpanBytesDecoder.PROTO3.decodeList(ByteBufUtil.getBytes(encodedBuf));
+ return SpanBytesDecoder.PROTO3.decodeList(encodedBuf.nioBuffer());
Review comment:
here is us decoding directly the bytebuffer in benchmarks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
