adriancole commented on a change in pull request #2589: Makes SpanBytesDecoder
work on ByteBuffer
URL: https://github.com/apache/incubator-zipkin/pull/2589#discussion_r283131606
##########
File path:
zipkin-storage/cassandra-v1/src/main/java/zipkin2/storage/cassandra/v1/SelectFromTraces.java
##########
@@ -163,7 +164,7 @@ public String toString() {
return (row, result) -> {
V1ThriftSpanReader reader = V1ThriftSpanReader.create();
V1SpanConverter converter = V1SpanConverter.create();
- V1Span read = reader.read(row.getBytes("span"));
+ V1Span read = reader.read(ReadBuffer.wrapUnsafe(row.getBytes("span")));
Review comment:
here cassandra is using the bytebuffer variant directly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
