adriancole commented on issue #2589: Makes SpanBytesDecoder work on ByteBuffer URL: https://github.com/apache/incubator-zipkin/pull/2589#issuecomment-491588627 results on JRE 11 are even better ``` ProtoCodecBenchmarks.bytebuffer_protobufDecoder:bytebuffer_protobufDecoder·p0.99 sample 1776.026 us/op ProtoCodecBenchmarks.bytebuffer_protobufDecoder:·gc.alloc.rate.norm sample 15 2007317.528 ± 17.585 B/op ProtoCodecBenchmarks.bytebuffer_wireDecoder:bytebuffer_wireDecoder·p0.99 sample 2129.469 us/op ProtoCodecBenchmarks.bytebuffer_wireDecoder:·gc.alloc.rate.norm sample 15 1971521.040 ± 20.325 B/op ProtoCodecBenchmarks.bytebuffer_zipkinDecoder:bytebuffer_zipkinDecoder·p0.99 sample 1586.258 us/op ProtoCodecBenchmarks.bytebuffer_zipkinDecoder:·gc.alloc.rate.norm sample 15 1591251.722 ± 17.422 B/op ProtoCodecBenchmarks.bytes_protobufDecoder:bytes_protobufDecoder·p0.99 sample 1520.026 us/op ProtoCodecBenchmarks.bytes_protobufDecoder:·gc.alloc.rate.norm sample 15 1919189.226 ± 23.622 B/op ProtoCodecBenchmarks.bytes_wireDecoder:bytes_wireDecoder·p0.99 sample 1952.563 us/op ProtoCodecBenchmarks.bytes_wireDecoder:·gc.alloc.rate.norm sample 15 1971395.380 ± 20.724 B/op ProtoCodecBenchmarks.bytes_zipkinDecoder:bytes_zipkinDecoder·p0.99 sample 1371.259 us/op ProtoCodecBenchmarks.bytes_zipkinDecoder:·gc.alloc.rate.norm sample 15 1591151.095 ± 14.826 B/op ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
