adriancole commented on issue #2589: Makes SpanBytesDecoder work on ByteBuffer URL: https://github.com/apache/incubator-zipkin/pull/2589#issuecomment-491673101 I double-checked the GC relating to span decoding and it is still good compared to moshi (what we use to read nested elasticsearch responses) ``` JsonCodecBenchmarks.bytebuffer_moshiDecoder:bytebuffer_moshiDecoder·p0.99 sample 6416.712 us/op JsonCodecBenchmarks.bytebuffer_moshiDecoder:·gc.alloc.rate.norm sample 15 4793152.590 ± 165.315 B/op JsonCodecBenchmarks.bytebuffer_zipkinDecoder:bytebuffer_zipkinDecoder·p0.99 sample 4600.463 us/op JsonCodecBenchmarks.bytebuffer_zipkinDecoder:·gc.alloc.rate.norm sample 15 3234258.812 ± 103.979 B/op JsonCodecBenchmarks.bytes_moshiDecoder:bytes_moshiDecoder·p0.99 sample 5892.997 us/op JsonCodecBenchmarks.bytes_moshiDecoder:·gc.alloc.rate.norm sample 15 5240585.937 ± 16702.252 B/op JsonCodecBenchmarks.bytes_zipkinDecoder:bytes_zipkinDecoder·p0.99 sample 5038.080 us/op JsonCodecBenchmarks.bytes_zipkinDecoder:·gc.alloc.rate.norm sample 15 3234750.088 ± 2432.093 B/op ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
