Repository: zookeeper Updated Branches: refs/heads/branch-3.5 576090432 -> f25c95ada
ZOOKEEPER-2716: Flaky Test: org.apache.zookeeper.server.SessionTrackerTest.testAddSessionAfterSessionExpiry We can't let the gate open until we increase the closed session count. Otherwise depends on timing, the test thread might see old session close count value between gate open and the session count actually gets increased. Author: Michael Han <[email protected]> Reviewers: Abraham Fine <[email protected]>, Rakesh Radhakrishnan <[email protected]> Closes #187 from hanm/ZOOKEEPER-2716 (cherry picked from commit 86438f9c6e65b2a95d709bf575cdcc2abc1c2e8b) Signed-off-by: Rakesh Radhakrishnan <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/zookeeper/repo Commit: http://git-wip-us.apache.org/repos/asf/zookeeper/commit/f25c95ad Tree: http://git-wip-us.apache.org/repos/asf/zookeeper/tree/f25c95ad Diff: http://git-wip-us.apache.org/repos/asf/zookeeper/diff/f25c95ad Branch: refs/heads/branch-3.5 Commit: f25c95adada51dc5c7519d3b8d6a1bb0d542ee68 Parents: 5760904 Author: Michael Han <[email protected]> Authored: Thu Mar 16 21:43:45 2017 +0530 Committer: Rakesh Radhakrishnan <[email protected]> Committed: Thu Mar 16 21:44:46 2017 +0530 ---------------------------------------------------------------------- src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zookeeper/blob/f25c95ad/src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java ---------------------------------------------------------------------- diff --git a/src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java b/src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java index 87aa73e..00e34fa 100644 --- a/src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java +++ b/src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java @@ -143,8 +143,8 @@ public class SessionTrackerTest extends ZKTestCase { public void processRequest(Request request) { // check session close request if (request.type == OpCode.closeSession) { - latch.countDown(); countOfCloseSessionReq++; + latch.countDown(); } }
