Repository: zookeeper Updated Branches: refs/heads/branch-3.4 1b59e3cde -> 3e5000f5f
ZOOKEEPER-2716: Flaky Test: org.apache.zookeeper.server.SessionTrackerTest.testAddSessionAfterSessionExpiry We can't let the gate open until we increase the closed session count. Otherwise depends on timing, the test thread might see old session close count value between gate open and the session count actually gets increased. Author: Michael Han <[email protected]> Reviewers: Abraham Fine <[email protected]>, Rakesh Radhakrishnan <[email protected]> Closes #187 from hanm/ZOOKEEPER-2716 (cherry picked from commit 86438f9c6e65b2a95d709bf575cdcc2abc1c2e8b) Signed-off-by: Rakesh Radhakrishnan <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/zookeeper/repo Commit: http://git-wip-us.apache.org/repos/asf/zookeeper/commit/3e5000f5 Tree: http://git-wip-us.apache.org/repos/asf/zookeeper/tree/3e5000f5 Diff: http://git-wip-us.apache.org/repos/asf/zookeeper/diff/3e5000f5 Branch: refs/heads/branch-3.4 Commit: 3e5000f5f5b30b838db709fa95228e556612eacf Parents: 1b59e3c Author: Michael Han <[email protected]> Authored: Thu Mar 16 21:43:45 2017 +0530 Committer: Rakesh Radhakrishnan <[email protected]> Committed: Thu Mar 16 21:46:26 2017 +0530 ---------------------------------------------------------------------- src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zookeeper/blob/3e5000f5/src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java ---------------------------------------------------------------------- diff --git a/src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java b/src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java index 61072e6..f427102 100644 --- a/src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java +++ b/src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java @@ -143,8 +143,8 @@ public class SessionTrackerTest extends ZKTestCase { public void processRequest(Request request) { // check session close request if (request.type == OpCode.closeSession) { - latch.countDown(); countOfCloseSessionReq++; + latch.countDown(); } }
