[
https://issues.apache.org/jira/browse/HADOOP-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730978#action_12730978
]
Doug Cutting commented on HADOOP-6120:
--------------------------------------
Looks good. Some comments:
- in AvroSerialization, s/GenericDatum{Reader,Writer}/Datum{Reader,Writer}/?
All implementations will probably always use a subclass of Generic, but it
feels to me like this API should be more abstract, no?
- in AvroReflectSerialization, 'List<String> packages' might be more efficient
as Set<String>?
- in AvroReflectSerialization, getPackages() could use
Configuration#getStrings().
- does Avro's reflect API actually require that fields are public? Specific
always generates public fields, but I think reflect should be able to serialize
and deserialize private fields. If not, maybe we should fix that in Avro?
> Add support for Avro types in hadoop
> ------------------------------------
>
> Key: HADOOP-6120
> URL: https://issues.apache.org/jira/browse/HADOOP-6120
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Sharad Agarwal
> Assignee: Sharad Agarwal
> Attachments: 6120_v1.patch, 6120_v2.patch
>
>
> Support to serialize and deserialize Avro types in Hadoop.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
