[
https://issues.apache.org/jira/browse/HADOOP-6224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749639#action_12749639
]
Hong Tang commented on HADOOP-6224:
-----------------------------------
I am actually a bit surprised by the patch.
- One minor point: Would it be better readStringSafely move to WritableUtils?
- One serious question: I am not sure why we need to open up the internal
Buffer class of DataOutputBuffer, or need to support the construction based on
an external byte[]. For the least, the ctor should clearly identify the
ownership of the byte[]. But based on the implementation of DataOutputBuffer,
it seems that the ownership has to be transferred to DataOutputBuffer and the
caller of this ctor should not retain the reference to byte[].
> Add some utility methods to Text and DataOutputBuffer to be used by
> MAPREDUCE-318
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-6224
> URL: https://issues.apache.org/jira/browse/HADOOP-6224
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Reporter: Jothi Padmanabhan
> Assignee: Jothi Padmanabhan
> Fix For: 0.21.0
>
> Attachments: common.patch
>
>
> MAPREDUCE-318 needs some minor extensions to the Text and the
> DataOutputBuffer classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
