[
https://issues.apache.org/jira/browse/HADOOP-6224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750008#action_12750008
]
Konstantin Boudnik commented on HADOOP-6224:
--------------------------------------------
- Using class name qualifier
{{+ int length = WritableUtils.readVInt(in);}}
seems to be unnecessary since the method belongs to {{WritableUtils}} now
- I'd suggest to change the exception argument's message from
{noformat}
+ throw new IllegalArgumentException("String size was " + length +
+ ", which is outside of 0.." +
+ maxLength);
{noformat}
to
{noformat}
+ throw new IllegalArgumentException("String size was " + length +
+ ", which is out of 0.." +
+ maxLength + " range.");
{noformat}
> Add some utility methods to Text and DataOutputBuffer to be used by
> MAPREDUCE-318
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-6224
> URL: https://issues.apache.org/jira/browse/HADOOP-6224
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Reporter: Jothi Padmanabhan
> Assignee: Jothi Padmanabhan
> Fix For: 0.21.0
>
> Attachments: common.patch, hadoop-6224.patch
>
>
> MAPREDUCE-318 needs some minor extensions to the Text and the
> DataOutputBuffer classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
