[
https://issues.apache.org/jira/browse/HADOOP-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765161#action_12765161
]
Todd Lipcon commented on HADOOP-6311:
-------------------------------------
bq. This might be acceptable if you can get the Android project to make
releases that we can use. (Or if they split it out into a stand alone project
that they also use...)
I think there's little chance of this. The original code has (a) some android
specific things like a special android socket namespace, (b) reliance on their
custom build system, and (c) reliance on a bunch of other utility code
elsewhere in Android. This is also such a small part of Android that I am
confident they'd have no interest in splitting it out to a separate library -
it would just be a waste of time for them.
Regarding maintenance and bugs, I think if you look at the code you'll see that
it's not super complicated; obviously there's always a chance for bugs,
especially on different platforms, but I don't see this code evolving much from
where it is today (in Android it has had only one edit in the year since it was
contributed). Also, since Android targets a very specific platform (and
specific nonstandard JVM, even) I don't think we'd see the same bugs they would
in practice.
bq. until we have another use of unix domain sockets within Hadoop, or at least
have another expected use, keep the code with its single user in HDFS.
I put this code in common since that's the easiest integration point for
additional native code. If I were to put it in an entirely separate JNI
library, we'd have to make changes to (or duplicate) NativeCodeLoader, ask
users to install multiple native libraries, add appropriate build
infrastructure to the hdfs build, etc. I think it makes most sense to have a
single "native-code based optimizations" library that contains these optional
extensions in common even if there is currently only a single user.
> Add support for unix domain sockets to JNI libs
> -----------------------------------------------
>
> Key: HADOOP-6311
> URL: https://issues.apache.org/jira/browse/HADOOP-6311
> Project: Hadoop Common
> Issue Type: New Feature
> Components: native
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hadoop-6311.txt
>
>
> For HDFS-347 we need to use unix domain sockets. This JIRA is to include a
> library in common which adds a o.a.h.net.unix package based on the code from
> Android (apache 2 license)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
