[
https://issues.apache.org/jira/browse/HADOOP-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765199#action_12765199
]
Todd Lipcon commented on HADOOP-6311:
-------------------------------------
bq. You propose to commit MBs of new code, which we don't know nothing about
and take the burden of supporting it, if I understood Doug correctly.
As I said above, the patch is huge due to having to rerun autoconf/aclocal/etc.
The actual amount of new code in the patch:
{noformat}
build.xml | 10 +
.../org/apache/hadoop/net/unix/Credentials.java | 52 +
.../apache/hadoop/net/unix/LocalServerSocket.java | 122 +
.../org/apache/hadoop/net/unix/LocalSocket.java | 288 +
.../apache/hadoop/net/unix/LocalSocketAddress.java | 95 +
.../apache/hadoop/net/unix/LocalSocketImpl.java | 499 +
.../src/org/apache/hadoop/net/unix/JNIHelp.cpp | 85 +
.../src/org/apache/hadoop/net/unix/JNIHelp.h | 76 +
.../src/org/apache/hadoop/net/unix/Makefile.am | 51 +
.../hadoop/net/unix/java_io_FileDescriptor.cpp | 201 +
.../org_apache_hadoop_net_unix_LocalSocketImpl.cpp | 1012 +
.../apache/hadoop/net/unix/TestLocalSockets.java | 208 +
{noformat}
So, this isn't a tiny patch, but it's certainly not huge either. If you
discount comments and whitespace, it's 867 lines of cpp, 628 lines of java (120
are test).
If you prefer, I can rip out all of the code but the very minimal required, but
I don't consider this a particularly large patch.
As for alternatives, I think many of them were thrown out due to security
concerns in HDFS-347. I will certainly look into Raghu's proposed improvement
to FSInputChecker, and if that gets the same gains as this, I'm happy to throw
out all of the localsockets complication.
> Add support for unix domain sockets to JNI libs
> -----------------------------------------------
>
> Key: HADOOP-6311
> URL: https://issues.apache.org/jira/browse/HADOOP-6311
> Project: Hadoop Common
> Issue Type: New Feature
> Components: native
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hadoop-6311.txt
>
>
> For HDFS-347 we need to use unix domain sockets. This JIRA is to include a
> library in common which adds a o.a.h.net.unix package based on the code from
> Android (apache 2 license)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
