[ 
https://issues.apache.org/jira/browse/HADOOP-6730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862404#action_12862404
 ] 

Eli Collins commented on HADOOP-6730:
-------------------------------------

Hey Ravi,  per the previous comment I left the getFileStatus outside the try 
block so the FileNotFoundException is now swallowed silently and is thrown up 
to copy (whose API wants FileNotFoundThrown). This deserves a comment.

The patch just has util classes - perhaps you forgot to add the test class in 
your diff?

> Bug in FileContext#copy
> -----------------------
>
>                 Key: HADOOP-6730
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6730
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.22.0
>            Reporter: Eli Collins
>            Assignee: Ravi Phulari
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6730.patch
>
>
> Thanks to Eli, He noticed that there is no test for FileContext#Copy 
> operation. 
> On further investigation with the help of Sanjay we found that there is bug 
> in FileContext#checkDest.
> {noformat}
>   FileStatus dstFs = getFileStatus(dst);
>     try {
>       if (dstFs.isDir()) {
>         if (null == srcNa
> {noformat}
>  *FileStatus dstFs = getFileStatus(dst);* should be in try...catch block.
> {noformat}
>     try {
>        FileStatus dstFs = getFileStatus(dst);
>        if (dstFs.isDir()) {
>           if (null == srcNa
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to