[ https://issues.apache.org/jira/browse/HADOOP-6730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862955#action_12862955 ]
Hadoop QA commented on HADOOP-6730: ----------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443315/HADOOP-6730.4.patch against trunk revision 939864. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/492/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/492/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/492/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/492/console This message is automatically generated. > Bug in FileContext#copy > ----------------------- > > Key: HADOOP-6730 > URL: https://issues.apache.org/jira/browse/HADOOP-6730 > Project: Hadoop Common > Issue Type: Bug > Components: fs > Affects Versions: 0.21.0, 0.22.0 > Reporter: Eli Collins > Assignee: Ravi Phulari > Fix For: 0.21.0, 0.22.0 > > Attachments: HADOOP-6730.2.patch, HADOOP-6730.3.patch, > HADOOP-6730.4.patch, HADOOP-6730.patch > > > Thanks to Eli, He noticed that there is no test for FileContext#Copy > operation. > On further investigation with the help of Sanjay we found that there is bug > in FileContext#checkDest. > {noformat} > FileStatus dstFs = getFileStatus(dst); > try { > if (dstFs.isDir()) { > if (null == srcNa > {noformat} > *FileStatus dstFs = getFileStatus(dst);* should be in try...catch block. > {noformat} > try { > FileStatus dstFs = getFileStatus(dst); > if (dstFs.isDir()) { > if (null == srcNa > {noformat} -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.