[
https://issues.apache.org/jira/browse/HADOOP-11262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082104#comment-15082104
]
Chris Nauroth commented on HADOOP-11262:
----------------------------------------
Patch v8 looks great overall. Thanks, everyone! I have just one question and
one minor nitpick.
{code}
@Override
public long getModificationTime(){
if(isDirectory()){
return System.currentTimeMillis();
} else {
return super.getModificationTime();
}
}
{code}
YARN resource localization includes a check of the modification time against
the source file system. (See {{FSDownload#copy}}.) I believe the intent is to
ensure that the state of the resources at application submission time remains
the same at the time of launching the application's containers. Has anyone
tested resource localization sourced from S3A? I expect an ever-changing
modification time like this would trigger an error.
I see you're using the strategy of overriding some irrelevant/unsupported test
methods to be no-ops in the subclasses. Could you please put the {{@Ignore}}
annotation on these?
> Enable YARN to use S3A
> -----------------------
>
> Key: HADOOP-11262
> URL: https://issues.apache.org/jira/browse/HADOOP-11262
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Thomas Demoor
> Assignee: Pieter Reuse
> Labels: amazon, s3
> Attachments: HADOOP-11262-2.patch, HADOOP-11262-3.patch,
> HADOOP-11262-4.patch, HADOOP-11262-5.patch, HADOOP-11262-6.patch,
> HADOOP-11262-7.patch, HADOOP-11262-8.patch, HADOOP-11262.patch
>
>
> Uses DelegateToFileSystem to expose S3A as an AbstractFileSystem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
