[jira] [Commented] (HADOOP-11613) Remove httpclient dependency from hadoop-azure

[Masatake Iwasaki (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HADOOP-11613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153923#comment-15153923
 ] 

Masatake Iwasaki commented on HADOOP-11613:
-------------------------------------------

Thanks for the update, [~ajisakaa].

{code}
32          // BitSet equals to URI.allowed_abs_path.
33          BitSet expected = new BitSet();
34          expected.set(33);
35          expected.set(36);
36          expected.set(38, 43);
37          expected.set(44, 60);
38          expected.set(61);
39          expected.set(64, 91);
40          expected.set(95);
41          expected.set(97, 123);
42          expected.set(126);
43          Assert.assertEquals(expected, URIUtil.ALLOWED_ABS_PATH);
{code}

I think we should use char rather than int to make it more readable which chars 
are expected to be "allowed" like

{code}
    for (int i = 'a'; i <= 'z'; i++) {
      expected.set(i);
    }
    for (int i = 'A'; i <= 'Z'; i++) {
      expected.set(i);
    }
    // numeric characters
    for (int i = '0'; i <= '9'; i++) {
      expected.set(i);
    }
    ...
{code}

> Remove httpclient dependency from hadoop-azure
> ----------------------------------------------
>
>                 Key: HADOOP-11613
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11613
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Akira AJISAKA
>            Assignee: Brahma Reddy Battula
>              Labels: BB2015-05-TBR
>         Attachments: HADOOP-11613-001.patch, HADOOP-11613-002.patch, 
> HADOOP-11613-003.patch, HADOOP-11613.004.patch, HADOOP-11613.05.patch, 
> HADOOP-11613.06.patch, HADOOP-11613.patch
>
>
> Remove httpclient dependency from MockStorageInterface.java.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)