[ 
https://issues.apache.org/jira/browse/HADOOP-12831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159691#comment-15159691
 ] 

Li Lu commented on HADOOP-12831:
--------------------------------

Thanks for the quick patch [~liuml07]! Yes a precondition may make sense. 

One nit:
{code}
bytes per checksum too small
{code}
Maybe we can explicitly tell the user what is the valid range of the value? 
"Too small" looks very vague. 


> LocalFS/FSOutputSummer NPEs in constructor if bytes per checksum  set to 0
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-12831
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12831
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 2.8.0
>            Reporter: Steve Loughran
>            Assignee: Mingliang Liu
>            Priority: Minor
>         Attachments: HADOOP-12831.000.patch
>
>
> If you set the number of bytes per checksum to zero, 
> {code}    
> conf.setInt(LocalFileSystemConfigKeys.LOCAL_FS_BYTES_PER_CHECKSUM_KEY, 0)
> {code}
> then create a "file://" instance, you get to see a stack trace



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to