[ 
https://issues.apache.org/jira/browse/HADOOP-11540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193697#comment-15193697
 ] 

Colin Patrick McCabe commented on HADOOP-11540:
-----------------------------------------------

Thanks, [~drankye].

{{doEncodeByConvertingToDirectBuffers}}: this seems like a utility function 
that should go in {{RSUtil.java}} or another static utility class like that 
rather than in a base class, since hopefully most implementations won't need to 
use it.  Similar with {{doDecodeByConvertingToDirectBuffers}}, 
{{convertInputBuffer}}, etc.

{{AbstractNativeRawDecoder#initOutputs}}: we shouldn't need this.  Instead, 
implementations that have a more efficient version of resetBuffer can just 
override that function, right?  The same with 
{{AbstractNativeRawEncoder#initOutputs}}.

> Raw Reed-Solomon coder using Intel ISA-L library
> ------------------------------------------------
>
>                 Key: HADOOP-11540
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11540
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: HDFS-7285
>            Reporter: Zhe Zhang
>            Assignee: Kai Zheng
>         Attachments: HADOOP-11540-initial.patch, HADOOP-11540-v1.patch, 
> HADOOP-11540-v2.patch, HADOOP-11540-v4.patch, HADOOP-11540-v5.patch, 
> HADOOP-11540-with-11996-codes.patch, Native Erasure Coder Performance - Intel 
> ISAL-v1.pdf
>
>
> This is to provide RS codec implementation using Intel ISA-L library for 
> encoding and decoding.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to