[
https://issues.apache.org/jira/browse/HADOOP-11540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198567#comment-15198567
]
Kai Zheng commented on HADOOP-11540:
------------------------------------
Thanks [~cmccabe].
bq. I feel like having so much use of inheritance makes the code hard to
follow. That's why I argued that doEncodeByConvertingToDirectBuffers should be
in RSUtil.java.
Not considering doEncodeByConvertingToDirectBuffers, there is already some
codes in {{AbstractNativeRawEncoder}}. The AbstractNativeRawEncoder class can
be shared by various native encoders, like this RS one and later XOR one.
bq. Why not have the Java coders reset the buffers at the beginning as well,
then?
Good question! I believe this will simplify the codes much and better!!
> Raw Reed-Solomon coder using Intel ISA-L library
> ------------------------------------------------
>
> Key: HADOOP-11540
> URL: https://issues.apache.org/jira/browse/HADOOP-11540
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: HDFS-7285
> Reporter: Zhe Zhang
> Assignee: Kai Zheng
> Attachments: HADOOP-11540-initial.patch, HADOOP-11540-v1.patch,
> HADOOP-11540-v2.patch, HADOOP-11540-v4.patch, HADOOP-11540-v5.patch,
> HADOOP-11540-with-11996-codes.patch, Native Erasure Coder Performance - Intel
> ISAL-v1.pdf
>
>
> This is to provide RS codec implementation using Intel ISA-L library for
> encoding and decoding.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
