[ 
https://issues.apache.org/jira/browse/HADOOP-12902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211297#comment-15211297
 ] 

Akira AJISAKA commented on HADOOP-12902:
----------------------------------------

Thanks [~gliptak] for creating the patch.
{code}
  * <li>[#PREFIX#.]signature.secret: when signer.secret.provider is set to
- * "string" or not specified, this is the value for the secret used to sign the
+ * "file" or not specified, this is the value for the secret used to sign the
{code}
Reading the source code, it seems that {{\[#PREFIX#.]signature.secret}} is not 
valid now. When "file" is specified, {{\[#PREFIX#.\]signature.secret.file}} is 
the file path which the secret is loaded from. Would you update the patch to 
document {{\[#PREFIX#.\]signature.secret.file}}?

> JavaDocs for SignerSecretProvider are out-of-date in AuthenticationFilter
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-12902
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12902
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 2.7.0
>            Reporter: Robert Kanter
>            Assignee: Gabor Liptak
>              Labels: newbie
>         Attachments: HADOOP-12902.1.patch
>
>
> The Javadocs in {{AuthenticationFilter}} say:
> {noformat}
>  * Out of the box it provides 3 signer secret provider implementations:
>  * "string", "random", and "zookeeper"
> {noformat}
> However, the "string" implementation is no longer available because 
> HADOOP-11748 moved it to be a test-only artifact.  This also doesn't mention 
> anything about the file-backed secret provider ({{FileSignerSecretProvider}}).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to