[
https://issues.apache.org/jira/browse/HADOOP-12902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213809#comment-15213809
]
Akira AJISAKA commented on HADOOP-12902:
----------------------------------------
Thanks [~gliptak] for updating the patch! 3 comments:
{code}
- * <li>[#PREFIX#.]signature.secret: When the "string" implementation is
+ * <li>[#PREFIX#.]signature.secret: When the "file" implementation is
* specified, this value is used as the secret.</li>
{code}
1. Would you fix the above as well?
{code}
- * Possible values are: "string", "random", "zookeeper", or a classname.
- * If not specified, the "string" implementation will be used with
+ * Possible values are: "file", "random", "zookeeper", or a classname.
+ * If not specified, the "file" implementation will be used with
* SIGNATURE_SECRET; and if that's not specified, the "random" implementation
{code}
2. {{SIGNATURE_SECRET}} should be {{SIGNATURE_SECRET_FILE}}.
3. Would you fix the checkstyle warning?
> JavaDocs for SignerSecretProvider are out-of-date in AuthenticationFilter
> -------------------------------------------------------------------------
>
> Key: HADOOP-12902
> URL: https://issues.apache.org/jira/browse/HADOOP-12902
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.7.0
> Reporter: Robert Kanter
> Assignee: Gabor Liptak
> Labels: newbie
> Attachments: HADOOP-12902.1.patch, HADOOP-12902.2.patch
>
>
> The Javadocs in {{AuthenticationFilter}} say:
> {noformat}
> * Out of the box it provides 3 signer secret provider implementations:
> * "string", "random", and "zookeeper"
> {noformat}
> However, the "string" implementation is no longer available because
> HADOOP-11748 moved it to be a test-only artifact. This also doesn't mention
> anything about the file-backed secret provider ({{FileSignerSecretProvider}}).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
