[
https://issues.apache.org/jira/browse/HADOOP-11540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231248#comment-15231248
]
Kai Zheng commented on HADOOP-11540:
------------------------------------
Thanks [~cmccabe] for the once more review!
bq. Is it intentional that the "output" parameter is ignored here?
Yes it's intended here, because there is actually nothing/content to convert
since the only need is to allocate a direct bytebuffer. I will check thru the
codes and see if better to clean up.
bq. Why not just have the encode() function zero the buffer in every case? I
don't see why the pure java code benefits from doing this differently-- and it
is much simpler to understand if all the coders do it the same way.
I agree it will be easier to understand. The only thing I'm not sure about is,
there are at least 6 Java coders and 2 x 6 encode/decode functions right now,
if adding a loop to reset the list of output buffers to each function, it looks
like a major change here. That's why I put the common codes in the abstract
class. How about introducing AbstractJavaRawEncoder/AbstractJavaRawDecoder
similar to the native ones for such things, then we can get rid of
{{wantInitOutputs}} and don't have to change into each Java coders?
bq. All these functions can fail. You need to check for, and handle their
failures.
I agree, even though they're simple calls.
bq. isAllowingChangeInputs, isAllowingVerboseDump: should be allowChangeInputs,
allowVerboseDump for clarity.
Right, I will do it.
> Raw Reed-Solomon coder using Intel ISA-L library
> ------------------------------------------------
>
> Key: HADOOP-11540
> URL: https://issues.apache.org/jira/browse/HADOOP-11540
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: HDFS-7285
> Reporter: Zhe Zhang
> Assignee: Kai Zheng
> Attachments: HADOOP-11540-initial.patch, HADOOP-11540-v1.patch,
> HADOOP-11540-v10.patch, HADOOP-11540-v2.patch, HADOOP-11540-v4.patch,
> HADOOP-11540-v5.patch, HADOOP-11540-v6.patch, HADOOP-11540-v7.patch,
> HADOOP-11540-v8.patch, HADOOP-11540-v9.patch,
> HADOOP-11540-with-11996-codes.patch, Native Erasure Coder Performance - Intel
> ISAL-v1.pdf
>
>
> This is to provide RS codec implementation using Intel ISA-L library for
> encoding and decoding.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
