[
https://issues.apache.org/jira/browse/HADOOP-11540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231306#comment-15231306
]
Colin Patrick McCabe commented on HADOOP-11540:
-----------------------------------------------
Thanks, [~drankye]. Good progress here.
bq. I agree it will be easier to understand. The only thing I'm not sure about
is, there are at least 6 Java coders and 2 x 6 encode/decode functions right
now, if adding a loop to reset the list of output buffers to each function, it
looks like a major change here. That's why I put the common codes in the
abstract class.
Hmm. I still think changing the Java coders is the simplest thing to do. It's
a tiny amount of code, or should be (calling one function), and simple to
understand.
bq. How about introducing AbstractJavaRawEncoder/AbstractJavaRawDecoder similar
to the native ones for such things, then we can get rid of wantInitOutputs and
don't have to change into each Java coders?
I don't think this would be a good idea. We need to start thinking about
simplifying the inheritance hierarchy and getting rid of some levels. We have
too many non-abstract base classes, which makes it difficult to follow.
Inheritance should not be used to accomplish code reuse, only to express a
genuine is-a relationship.
> Raw Reed-Solomon coder using Intel ISA-L library
> ------------------------------------------------
>
> Key: HADOOP-11540
> URL: https://issues.apache.org/jira/browse/HADOOP-11540
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: HDFS-7285
> Reporter: Zhe Zhang
> Assignee: Kai Zheng
> Attachments: HADOOP-11540-initial.patch, HADOOP-11540-v1.patch,
> HADOOP-11540-v10.patch, HADOOP-11540-v2.patch, HADOOP-11540-v4.patch,
> HADOOP-11540-v5.patch, HADOOP-11540-v6.patch, HADOOP-11540-v7.patch,
> HADOOP-11540-v8.patch, HADOOP-11540-v9.patch,
> HADOOP-11540-with-11996-codes.patch, Native Erasure Coder Performance - Intel
> ISAL-v1.pdf
>
>
> This is to provide RS codec implementation using Intel ISA-L library for
> encoding and decoding.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
