[
https://issues.apache.org/jira/browse/HADOOP-12957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264732#comment-15264732
]
Tsz Wo Nicholas Sze commented on HADOOP-12957:
----------------------------------------------
- asyncCallCounter should be final
- The AsyncCallLimitExceededException message should include the value of the
limit and describle how to config it. Also, we don't need LOG.warn(..).
Throwing an exception is good enough.
- Callbacks (i.e. Callable) do not need the AtomicBoolean called field.
- The RETURN_VALUE_CALLBACK actually can be removed since it does nothing.
AsyncDistributedFileSystem can directly call
ProtobufRpcEngine.getReturnMessageCallback().
> Limit the number of outstanding async calls
> -------------------------------------------
>
> Key: HADOOP-12957
> URL: https://issues.apache.org/jira/browse/HADOOP-12957
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Xiaobing Zhou
> Assignee: Xiaobing Zhou
> Attachments: HADOOP-12957-HADOOP-12909.000.patch,
> HADOOP-12957-combo.000.patch, HADOOP-12957.001.patch, HADOOP-12957.002.patch,
> HADOOP-12957.003.patch, HADOOP-12957.004.patch, HADOOP-12957.005.patch
>
>
> In async RPC, if the callers don't read replies fast enough, the buffer
> storing replies could be used up. This is to propose limiting the number of
> outstanding async calls to eliminate the issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
